Handle wiring images #708
Handle wiring images #708
Conversation
jeremyrickard
force-pushed
the
handle-wiring-images
branch
from
7157b49 to
2a2b5e5
Compare
There was a problem hiding this comment.
Nice! Couple of Q's:
- Do these changes address the TODO in https://github.com/deislabs/porter/blob/master/pkg/manifest/manifest.go#L50-L51 ?
- Perhaps as a follow-up, it seems like the
OriginalImagefield in theImageMapstruct is no longer needed? https://github.com/deislabs/porter/blob/master/pkg/manifest/manifest.go#L264 (Or do we want to start populating/using it?)
|
@vdice nixed the Original Image and TODO comments |
|
I have an impending update of the relocation mapping. The format I had seen before isn't what is there for reals, so fixing that up at the moment. |
|
OK, this is updated now. The image relocation map looks like: Which means, we need to reverse from the bundle.json's image -> the name in the map in order to connect it back to the porter manifest. PR was updated to handle this and error if mappings are provided that don't exist. I suppose we could be more lenient in those cases, but I went with more strict to start out with. |
| @@ -102,6 +105,31 @@ func (p *Porter) Run(opts RunOptions) error { | |||
| return err | |||
| } | |||
|
|
|||
| //Update the runtimeManifest images with the bundle.json and relocation mapping (if it's there) | |||
There was a problem hiding this comment.
nit: In a follow up, it would be nice to wrap this all up in a function in this same file so that Run continues to be pretty readable at a high level. Maybe handleRelocationImages or something.
There was a problem hiding this comment.
good point, i'll do a follow up. I think i want to do a refactor of a bunch of the logic here
There was a problem hiding this comment.
Yeah based on the touched file list you showed me, a refactor doesn't seem like a bad idea if you have ideas on how to improve the abstraction.
What does this change
This change introduces additional run time wiring logic for the mustache like
bundle.imagesfunctionality. When a bundle is executed, thebundle.jsonand an optionalrelocation-mapping.jsonfile can be mounted into the invocation image. These can override the values present in theporter.yaml(which is inserted into the invocation image at build). The values provided by thebundle.jsonandrelocation-mapping.jsonshould override what is in theporter.yamlmanifest.What issue does it fix
Closes #692
Notes for the reviewer
👋 🌵
Checklist