Move manifest into separate package from config #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
refactor-config
branch
2 times, most recently
from
9d14c78 to
effea7b
Compare
carolynvs
commented
Oct 7, 2019
| ImageDigests: imageDigests, | ||
| } | ||
| } | ||
|
|
||
| func (c *ManifestConverter) ToBundle() *bundle.Bundle { | ||
| fmt.Fprintf(c.Out, "\nGenerating Bundle File with Invocation Image %s =======> \n", c.Manifest.Image) |
There was a problem hiding this comment.
I decided to remove these output lines, as doing a conversion from one data structure to another doesn't really warrant these log lines anymore. They maybe made sense last November for the prototype but now aren't necessary and are just noise.
carolynvs
commented
Oct 7, 2019
| url := "https://raw.githubusercontent.com/deislabs/porter/master/pkg/config/testdata/simple.porter.yaml" | ||
| m, err := c.ReadManifest(url) | ||
| c := config.NewTestConfig(t) | ||
| url := "https://raw.githubusercontent.com/deislabs/porter/v0.17.0-beta.1/pkg/config/testdata/simple.porter.yaml" |
There was a problem hiding this comment.
This file moved in the refactoring so I am using a tag for now to prevent the build from breaking when the PR is merged.
carolynvs
force-pushed
the
refactor-config
branch
from
effea7b to
428b006
Compare
This allows plugins to import porter config without also taking dependencies on everything related to the porter manifests (including our runtime manifest). They really are two separate concerns, porter's config and the bundle configuration, so this was a long time coming.
It's hard to see which test failed with verbose on
carolynvs
force-pushed
the
refactor-config
branch
from
428b006 to
5d01357
Compare
vdice
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
This allows plugins to import porter config without also taking dependencies on everything related to the porter manifests (including our runtime manifest). They really are two separate concerns, porter's config and the bundle configuration, so this was a long time coming.
What issue does it fix
This is preparatory refactoring for #701
Notes for the reviewer
Sorry for the large change but config is used everywhere...
Checklist