Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
The test for porter's schema was only checking that the schema was valid.
It wasn't checking that the porter.yaml validated against the schema... sad trombone
This fixes the test so that it fails when the schema drifts and prints all the problems with the schema.
This requires a sweep of all our mixins because of the change from patternProperties to additionalProperties so that mixins also fix the double validation problem.
What issue does it fix
Closes #662
Notes for the reviewer
Checklist