Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple kubernetes example #390

Merged
merged 2 commits into from
Jun 6, 2019

Conversation

jeremyrickard
Copy link
Contributor

No description provided.

@@ -0,0 +1,39 @@
# This is the configuration for Porter
# You must define steps for each action, but the rest is optional
# Uncomment out the sections below to take full advantage of what Porter can do!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you remove this comment section here? It doesn't really apply to your example

@@ -0,0 +1,46 @@
# My First Bundle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed (since it's talking about my first bundle, and an empty bundle) or edited to explain the example

@@ -0,0 +1,12 @@
FROM quay.io/deis/lightweight-docker-go:v0.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed since it's not being used by the example

@jeremyrickard
Copy link
Contributor Author

@carolynvs updated!

Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@carolynvs carolynvs merged commit 74157eb into getporter:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants