Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exec image wiring #3238

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Exec image wiring #3238

merged 2 commits into from
Oct 16, 2024

Conversation

jmcudd
Copy link
Contributor

@jmcudd jmcudd commented Oct 15, 2024

What does this change

Adds an additional example of how to wire bundled images with exec mixin.

What issue does it fix

It was not obvious how to wire images into a exec mixin and the only example in the documentation was for helm.

Notes for the reviewer

Put any questions or notes for the reviewer here.
In the process of learning how to wire bundled images I found a bug (#3237). There is a workaround to this bug which I didn't include in the documentation, but it might be useful to include it. Here is the workaround.

envs:
  IMAGE_whalesayd: <bundle repository>/my-bundle@${ bundle.images.whalesayd.digest }

This references the whalesayd image that is actually bundled in my-bundle. In all my testing, bundle.images.whalesayd.repository is actaully just referencing the upstream image, which is potentially not accessible in an airgapped environment.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Signed-off-by: John Cudd <jmcudd@gmail.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>
@jmcudd jmcudd force-pushed the exec-image-wiring branch from 36c2b88 to 03410ce Compare October 15, 2024 20:38
Copy link
Contributor

@kichristensen kichristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcudd Thanks for adding this to the documentation

@kichristensen kichristensen merged commit 9ece995 into getporter:main Oct 16, 2024
31 of 32 checks passed
robinbraemer pushed a commit to cnap-tech/porter that referenced this pull request Oct 18, 2024
* Example on how to wire an image via exec mixin

Signed-off-by: John Cudd <jmcudd@gmail.com>

* Small tweak to naming

Signed-off-by: John Cudd <jmcudd@gmail.com>

---------

Signed-off-by: John Cudd <jmcudd@gmail.com>
Signed-off-by: robinbraemer <robin.braemer@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants