Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message on malformed step #3052

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

kichristensen
Copy link
Contributor

What does this change

Instead of giving a cryptic error message, "more than one mixin specified", better describe the most likely cause of the problem, making it easier for people to understand what to fix.

What issue does it fix

Closes #370

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: Kim Christensen <kimworking@gmail.com>
@@ -23,6 +23,7 @@ import (
"github.com/cbroglie/mustache"
"github.com/cnabio/cnab-go/bundle"
"github.com/cnabio/cnab-go/bundle/definition"
"github.com/dustin/go-humanize"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This package seems to be not very maintained, but it doesn't seem to really need a lot. We've been using it already, so it's really nbd, but with recent security things going on I think I'm just hyper-aware for a bit :)
Just thinking out loud here.

@schristoff schristoff merged commit 7310b18 into getporter:main Apr 9, 2024
15 checks passed
@kichristensen kichristensen deleted the improveErrorMessage branch April 9, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poor error message: more than one mixin specified
2 participants