Commenting out lines to fix the bug of no such file or directory #2990
Conversation
Bharadwajshivam28
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
magefile.go
Outdated
| @@ -679,7 +679,7 @@ func Install() { | |||
| // Removing the file first clears the cache so that we don't run into "zsh: killed MIXIN..." | |||
| // See https://stackoverflow.com/questions/67378106/mac-m1-cping-binary-over-another-results-in-crash | |||
| // See https://openradar.appspot.com/FB8914231 | |||
| mgx.Must(os.Remove(filepath.Join(destDir, mixin+xplat.FileExt()))) | |||
| //mgx.Must(os.Remove(filepath.Join(destDir, mixin+xplat.FileExt()))) | |||
There was a problem hiding this comment.
This line was there for an issue on M1 Macs where there would be an error about the executable not being signed properly and wouldn't execute. Are you able to confirm you're not able to reproduce that error?
If so, you can just delete this line and all the comments addressing it :)
There was a problem hiding this comment.
Hey @schristoff give me some time will confirm it and drop a message here
|
Hey @schristoff I tested by removing lines 682-683 . It worked fine.. so we can remove both the lines |
|
I hit a similar issue and the same today. Almost the same eror can happen on line 648 and 649, when Porter is not installed initially, was about to create a PR to fix when I saw this one |
|
Hey @kichristensen thanks for letting us know, mind if I ask, are you on Mac and if so what architecture? |
|
@schristoff Unfortunately I'm not on Mac |
I faced the same issue on Linux(Manjaro) while setting it up... but commenting those lines fixes it |
Signed-off-by: shivam <shivambharadwaj822@gmail.com>
Signed-off-by: Shivam <shivambharadwaj822@gmail.com> Signed-off-by: shivam <shivambharadwaj822@gmail.com>
Signed-off-by: Shivam <shivambharadwaj822@gmail.com> Signed-off-by: shivam <shivambharadwaj822@gmail.com>
Signed-off-by: Shivam <shivambharadwaj822@gmail.com> Signed-off-by: shivam <shivambharadwaj822@gmail.com>
* Create user-friendly error message on missing porter.yaml Improve the error message when porter.yaml is missing during build Signed-off-by: Kim Christensen <kimworking@gmail.com> --------- Signed-off-by: Kim Christensen <kimworking@gmail.com> Signed-off-by: shivam <shivambharadwaj822@gmail.com>
What does this change
This fixes the Bug when we do Mage Install an error comes "no such file or directory"
What issue does it fix
fixes #2989
Notes for the reviewer
Please look into some points i raised in the issue comment section
Checklist
[contributors]: https://getporter.org/src/CONTRIBUTORS.md