Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish mixin feed during CI build #291

Merged
merged 7 commits into from
Apr 24, 2019

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Apr 23, 2019

This has the main change, which uses porter mixins feed generate to generate the mixin feed and upload it to our blob storage during a CI build.

It also has a bunch of little fixes to the feed generation and search that I found when testing the generate and install commands manually against real URLs.

  • Fix call to make temp directory. Oops that worked fine with the unit test, but borked on a real OS. Go figured. 😊
  • Don't mark the atom feed as executable when we download it and parse it. That was leftover from when I reused the same code to download a mixin binary.
  • Improve cleanup when downloading the atom file. Again, removed some problems from when I reused the same download code for the mixins, for downloading the atom feed file.
  • Fix typo in example, so that if they ran it the URL is usable.
  • Install the highest semver when asked for "latest" from an atom feed.

@ghost ghost assigned carolynvs Apr 23, 2019
@ghost ghost added the review label Apr 23, 2019
@carolynvs carolynvs force-pushed the publish-feed branch 2 times, most recently from c4fdc5e to dcb5102 Compare April 24, 2019 00:09
@carolynvs carolynvs merged commit 476b1b5 into getporter:master Apr 24, 2019
@carolynvs carolynvs deleted the publish-feed branch April 24, 2019 13:54
@ghost ghost removed the review label Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants