-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add v prefix #2890
Merged
Merged
add v prefix #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
ludfjig
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
August 29, 2023 21:46
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Amazing work! Are you able to add some test cases for this? |
/azp run porter-integration |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
schristoff
reviewed
Aug 30, 2023
schristoff
reviewed
Aug 30, 2023
schristoff
reviewed
Aug 30, 2023
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
schristoff
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
porter explain -r getporter/hello-llama:0.1.1
now prepends av
to the version (0.1.1), so that it will find the bundle if it is tagged v1.2.3 in the registry.What issue does it fix
Closes #2886
Notes for the reviewer
Put any questions or notes for the reviewer here.
Checklist
Reviewer Checklist