Do not encode -runtime into mixin download filename #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of requiring the runtime binary for the mixin to be uploaded as foo-runtime-linux-amd64, allow the client mixin for linux, which is foo-linux-amd64, to be reused as there is no difference. This sets us up anyway for when porter needs to support a customizable runtime image that could be a different os/arch.
ghost
assigned 
carolynvs
changed the title
carolynvs
changed the title
carolynvs
changed the title
carolynvs
force-pushed
the
runtime-download-name
branch
from
2bfba65 to
44df2fc
Compare
I took this opportunity to overhaul them makefiles with other changes: * install using porter mixin install * consolidate targets for the internal / external mixins
carolynvs
force-pushed
the
runtime-download-name
branch
from
44df2fc to
950a4d6
Compare
carolynvs
changed the title
|
Ok, boy that was harder than I expected. Silly make. This is ready for review. |
vdice
approved these changes
Apr 16, 2019
vdice
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring the runtime binary for the mixin to be uploaded as foo-runtime-linux-amd64, allow the client mixin for linux, which is foo-linux-amd64, to be reused as there is no difference.
This sets us up anyway for when porter needs to support a customizable runtime image that could be a different os/arch.
Note: This doesn't change the name of the file on the filesystem, just what we require the mixin author to upload it as.
After this PR, I'll update the azure, helm, and terraform repos, and then all of the mixins will have done a canary publish with the new naming conventiong