install mixin from url #265
Conversation
ghost
assigned 
Previously these were in embedded fields which caused collisions, as both mixins and cnab actions had "Install" or "Uninstall". Also it was confusing when porter needed to also have a composite function that handled installing a bundle that wrapped up functionality from the CNAB InstallBundle function. It was hard to know what to call when. So I've moved the interfaces for the CNAB and Mixin providers into named fields so that it's more clear which are the methods owned by the Porter struct (and should be used by the cli).
Explain how to publish a mixin that works with porter install
* Close gap between page title and initial content * Title should be h1
carolynvs
force-pushed
the
mixin-install
branch
from
7ddf925 to
f3ba003
Compare
|
Thanks for the solid review. I think all your comments have been addressed but it's now Friday at 5 sooooooooooooo 💨 |
carolynvs
force-pushed
the
mixin-install
branch
from
4730583 to
04e2b61
Compare
|
I'm going to leave out updating the cli.md file for now. It's so momumentally out of date it's not even funny and later figure out how to code-gen it from cobra. |
|
The test is failing on brigade because it runs as root, so my little trick of making a file that the current user can't read doesn't work. We can either keep the test, and not run as root, or fix/remove the test. I'm not sure of how else to sabotage that test though. Thoughts? |
|
Ah. Hmmm, I'm assuming running as a non-root user would require a non-trivial amount of work and affect all tests? Otherwise, my only idea would be to mock out and enable use of a test filesystem such that we can make sure Either way, it sounds a bit tricky and may not be worth the cost. I'll defer to your judgement here. |
|
I don't have an off the shelf fake tool for making those methods fail on demand. So for every variation of the test we'd have a hand rolled fake which is way too much effort for this test IMO. For now I vote to leave it off, unless someone else wants to try to tackle that later? We'd end up making a general purpose new type of AferoFS that can be told to sabotage any of its operations. I don't want to try to do that in this PR however, it could come in handy later if we wan to try to do fakes at that level in all of our tests. |
This implements the first part of mixin installation
for now --url is required, but once we introduce subscriptions (i.e. being able to follow all the mixins from deislabs) it won't be anymore.
Docs available at https://deploy-preview-265--porter.netlify.com/mixin-distribution/