feat(examples): make mysql server name a required param #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, installing this bundle would most definitely result in an error, as the server name was hard-coded. The ARM deployment error would look something like:
(tl;dr:
\"message\": \"Specified server name is already used.\"
)Therefore, in this PR, I propose to not only parameterize this value, but also not set a default and thus make it a required param when installing, say, via: