Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): make mysql server name a required param #241

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

vdice
Copy link
Member

@vdice vdice commented Mar 26, 2019

Previously, installing this bundle would most definitely result in an error, as the server name was hard-coded. The ARM deployment error would look something like:

Error: error deploying "mysql-azure-porter-demo-wordpress" in resource group "porter-test": error while waiting for deployment to complete: Code="DeploymentFailed" Message="At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-debug for usage details." Details=[{"code":"BadRequest","message":"{\r\n  \"error\": {\r\n    \"code\": \"ServerNameAlreadyExists\",\r\n    \"message\": \"Specified server name is already used.\"\r\n  }\r\n}"}]

(tl;dr: \"message\": \"Specified server name is already used.\")

Therefore, in this PR, I propose to not only parameterize this value, but also not set a default and thus make it a required param when installing, say, via:

porter install --insecure -c amw --param server_name=porter-amw-vdice

@ghost ghost assigned vdice Mar 26, 2019
@ghost ghost added the review label Mar 26, 2019
@carolynvs carolynvs merged commit 854b6c8 into getporter:master Mar 28, 2019
@ghost ghost removed the review label Mar 28, 2019
@vdice vdice deleted the feat/examples-required-param branch March 28, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants