feat(*): add upgrade action support #135
Conversation
ghost
assigned 
| copy(result[:len(m.Install)], dep.m.Install) | ||
| copy(result[len(m.Install):], m.Install) | ||
| m.Install = result | ||
| m.Install = prependSteps(dep.m.Install, m.Install) |
There was a problem hiding this comment.
👍 Yay! Thank you for tidying this up. It sparks much joy
| } | ||
| return m.Execute() | ||
| // re-use Install's logic | ||
| return m.Install(commandFile) |
There was a problem hiding this comment.
In a follow-on PR, it's up for grabs to anyone (doesn't have to be you!) who would like to extract the logic from m.Install into a function that is named a bit more generically so that all of these functions can call into it, maybe m.ExecuteScript so that we don't need this comment.
It's a bit confusing to see uninstall calling to install here. I know it's because exec is an odd-ball mixin. 😀
|
FYI, it's up to you if you want to prefix your PRs with feat/chore/fix. I don't mind, but I don't get too much out of it either. Just throwing that out there in case you weren't sure if it's required in these porter repos. |
Adds
upgradeaction support to porter (and theexecmixin).Closes #123