-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pkg/printer): add yaml and raw printers #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yaml printer is ready to ship after we either split it out or hash out here my questions on the raw printer.
pkg/printer/raw.go
Outdated
"io" | ||
) | ||
|
||
// PrintRaw is a printer that prints the provided value as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So raw is really a dump of the go structure? Let me know if I don't have that right.
What's the use case for this format? json and yaml I see people using that in scripts. If they are chaining the output of this new raw format into a Go program I want to make sure that maybe there isn't an easier way (like making it so that they can use our libraries and functions directly from their code). Or at least making sure that it's a consumable format (e.g. maybe we should be using %#v
instead).
Also once we have hammered out the use case, let's pick a name that describes the format more clearly, e.g. "go" or something along those lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to change to FormatPlaintext
per getporter/helm2-mixin#12 (comment)
919e39c
to
6300527
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick! Merge before it's 5pm somewhere. 💨
Ref: getporter/helm2-mixin#12
Adds
yaml
andraw
printers to the printer pkg.