-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): add azure-ark example #107
feat(examples): add azure-ark example #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, meant to make this a comment, not approve.
b70d3de
to
997bff4
Compare
One note: I figured since the porter-azure mixin PR that this example depends on (getporter/arm-mixin#6) was merged, I would be able to
Wanted to make sure we're aware of these two gotchas if not already... |
The way the builds are setup here's what get published when:
So we can either tag a commit on porter-azure, then porter will pick it up. Or we can say that really porter should be relying on canary (tip of master) from porter-azure in its makefile, not latest (last tag). What do you think? |
I didn't want to re-download the mixins on every build. Suggestions welcome on how to manage that better. I do have plans to make it easier to install plugins for users, but didn't have much on the backlog for managing this for ourselves (beyond what you just did, rm and redo the build). How about clean should remove the cached mixins? This was all put together 6 hours before KubeCon in the hotel lounge when we found out that we were going to show porter to people, so don't assume anything was by design. 😉 |
@vdice Thank you for trying this! Please take all my replies as happy, confused attempts to help. 😀 |
I've turned my comment explaining the release tags into documentation on the readme. #110 |
Ah, thank you @carolynvs for the clarification; indeed, I'm not surprised to hear both cases had been considered and that the defaults make sense!
This totally makes sense -- we might not want porter to grab the very latest (canary here). I agree, I think porter should grab the latest release of the azure mixin that we're confident in -- so, the first route of tagging when ready, to trigger the proper publishing. Good call.
I agree here, too -- when playing around with PHONY-izing, indeed, it didn't feel right to re-fetch external dependencies on every build. |
MAGIC! 🎩 ✨ Let me know when you feel good about a tag on porter-azure. In the meantime you can manually grab the canary binaries and use them locally to test. Maybe we need a new makefile target to make that easier to do? |
In my testing of this example, master branch of porter-azure looks good (newly-added storage template/functionality working swimmingly). If test automation ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the example!
Adds Porter example utilizing Azure Storage and a Helm-based Ark installation
Uses porter-azure mixin functionality PR'ed in getporter/arm-mixin#6
For development/testing, I built the porter-azure mixin binaries (from branch above) and copied them into the default porter location before a
porter build
,duffle install
, etc.:TODOs (assuming PR a candidate for merge):
deislabs