Skip to content

Commit

Permalink
Fix tests only working because of the bug
Browse files Browse the repository at this point in the history
These tests was assertion that the resulting Dockerfile was generated
with the bug fixed in the previous commit

Signed-off-by: Kim Christensen <kimworking@gmail.com>
  • Loading branch information
kichristensen committed Feb 14, 2024
1 parent 549315e commit acf1eab
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions pkg/build/testdata/missing-args-expected-output.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# syntax=docker/dockerfile-upstream:1.4.0
FROM ubuntu:latest
COPY mybin /cnab/app/

ARG BUNDLE_DIR
ARG BUNDLE_UID=65532
ARG BUNDLE_USER=nonroot
ARG BUNDLE_GID=0
RUN useradd ${BUNDLE_USER} -m -u ${BUNDLE_UID} -g ${BUNDLE_GID} -o
COPY mybin /cnab/app/

# exec mixin has no buildtime dependencies

RUN rm ${BUNDLE_DIR}/porter.yaml
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# syntax=docker/dockerfile-upstream:1.4.0
FROM ubuntu:light
ARG BUNDLE_DIR
COPY mybin /cnab/app/
ARG BUNDLE_DIR
ARG BUNDLE_UID=65532
ARG BUNDLE_USER=nonroot
ARG BUNDLE_GID=0
RUN useradd ${BUNDLE_USER} -m -u ${BUNDLE_UID} -g ${BUNDLE_GID} -o
ARG BUNDLE_DIR
COPY mybin /cnab/app/
# exec mixin has no buildtime dependencies

RUN rm ${BUNDLE_DIR}/porter.yaml
Expand Down

0 comments on commit acf1eab

Please sign in to comment.