Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong description on GKE example and link of Kubernetes example #17

Closed
joshuabezaleel opened this issue Feb 14, 2022 · 0 comments · Fixed by #28
Closed

Fix wrong description on GKE example and link of Kubernetes example #17

joshuabezaleel opened this issue Feb 14, 2022 · 0 comments · Fixed by #28
Labels
bug Oops, sorry! docs Markdown ahoy! Updates needed on porter.sh or in dev docs.

Comments

@joshuabezaleel
Copy link

Describe the bug

To Reproduce

Documentation.

Expected behavior

  • README for GKE contains description for GKE example.
  • Link for GKE best practice on KUbernetes example contains appropriate link.

Porter Command and Output

Documentation.

Version
@joshuabezaleel joshuabezaleel added the bug Oops, sorry! label Feb 14, 2022
@carolynvs carolynvs added the docs Markdown ahoy! Updates needed on porter.sh or in dev docs. label Feb 15, 2022
@carolynvs carolynvs transferred this issue from getporter/porter Sep 15, 2022
kichristensen added a commit that referenced this issue Aug 8, 2024
@kichristensen
Correct the link on how to connect to GKE
5b8ac02 
The link pointed to a non-existing page and to localhost.
This is mentioned in #17.
kichristensen added a commit that referenced this issue Aug 8, 2024
@kichristensen
Make the README in GKE example clear
536c55f 
Previously it wasn't clear that this example was specific for GKE.

mentioned in #17
@kichristensen kichristensen mentioned this issue Aug 8, 2024
Merged
kichristensen added a commit that referenced this issue Aug 8, 2024
@kichristensen
Correct the link on how to connect to GKE
b2d4917 
The link pointed to a non-existing page and to localhost.
This is mentioned in #17.

Signed-off-by: Kim Christensen <kmch@simcorp.com>
kichristensen added a commit that referenced this issue Aug 8, 2024
@kichristensen
Make the README in GKE example clear
9ed523a 
Previously it wasn't clear that this example was specific for GKE.

mentioned in #17

Signed-off-by: Kim Christensen <kmch@simcorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Oops, sorry! docs Markdown ahoy! Updates needed on porter.sh or in dev docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update docs getporter/examples
2 participants
@carolynvs @joshuabezaleel