Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep EOF newline in quickstart-generated files #3251

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Keep EOF newline in quickstart-generated files #3251

merged 2 commits into from
Jan 17, 2024

Conversation

snosratiershad
Copy link

@snosratiershad snosratiershad commented Nov 22, 2023 •
edited
Loading

As referenced in Jinja documentation about whitespace control: https://jinja.palletsprojects.com/en/3.1.x/templates/#whitespace-control

To keep single trailing newlines, configure Jinja to
keep_trailing_newline

I added this to our Jinja environment to keep EOL new line in tools scripts

Pull Request Checklist

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code # NOT REQUIRED
  • Updated documentation for changed code # NOT REQUIRED

fix: keep newline at the end of the file in tools
7466b13 
As referenced in Jinja documentation about whitespace control:
<https://jinja.palletsprojects.com/en/3.1.x/templates/#whitespace-control>
>  To keep single trailing newlines, configure Jinja to
>  `keep_trailing_newline`
I added this to our Jinja environment to keep EOL new line in tools
scripts
@justinmayer justinmayer changed the title fix: keep newline at the end of the file in tools Keep EOF newline in quickstart-generated files Jan 17, 2024
justinmayer
justinmayer approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @snosratiershad for the contribution and to @avaris for reviewing 😊

@justinmayer justinmayer merged commit f2ab4a1 into getpelican:master Jan 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmayer justinmayer justinmayer approved these changes

@avaris avaris avaris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snosratiershad @avaris @justinmayer