Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carry form language selection over to new form version #6621

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Feb 23, 2025

Closes #6579

Why is this the best possible solution? Were any other approaches considered?

I don’t think there’s anything significant to discuss here. We just need to check if the form we’re saving in our database is a new version of an existing one, and if so, copy the language.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The only change is copying the selected language when saving an updated version of an existing form. Please test cases with multiple forms to ensure the language copied to the new form comes from the latest version. For example:

  • Form v1: selected language – Spanish
  • Form v2: selected language – Polish

After downloading Form v3, the language should be Polish, not Spanish.

Do we need any specific form for testing your changes? If so, please attach one.

Any form with more than 1 language I've used:
languageTest.xlsx

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carry form language selection over to new form version
1 participant