Add pop-up with filename to EntityUpload #955
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes progress on getodk/central#589. It adds the pop-up with the filename to
EntityUpload
.What has been done to verify that this works as intended?
I added tests, and I also tried it out locally. There was some functionality related to displaying the request status that I wasn't able to verify manually.
EntityUpload
doesn't currently send any entities, so the request fails immediately. During development, I forced the request status<div>
to be visible so that I could style it. That said, we do have tests of this functionality.One area where we have more limited testing is displaying upload progress. I added tests of the
progress
prop ofEntityUploadPopup
, but I wasn't able to test theonUploadProgress
callback inEntityUpload
and howuploadProgress.value
is set in that component. See #127 for related discussion. I think it's OK just to verify this manually: the relevant logic is just a few lines.Before submitting this PR, please make sure you have:
npm run test
andnpm run lint
and confirmed all checks still pass OR confirm CircleCI build passes