Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glue: get_dev_endpoints, create_dev_endpoint, get_dev_endpoint #8487

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

Singha22
Copy link
Contributor

@Singha22 Singha22 commented Jan 13, 2025

Issue: #8488 (comment)

New Boto Methods Added

  • get_dev_endpoints()
  • create_dev_endpoint()
  • get_dev_endpoints()

@Singha22 Singha22 changed the title Glue: get_dev_endpoints, create_dev_endpoint, get_dev_endpoints Glue: get_dev_endpoints, create_dev_endpoint, get_dev_endpoint Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.64%. Comparing base (db72e95) to head (5ca2743).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
moto/glue/models.py 93.75% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8487    +/-   ##
========================================
  Coverage   92.63%   92.64%            
========================================
  Files        1225     1225            
  Lines      105792   105993   +201     
========================================
+ Hits        97996    98192   +196     
- Misses       7796     7801     +5     
Flag Coverage Δ
servertests 27.75% <10.66%> (-0.01%) ⬇️
unittests 92.61% <96.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Singha22 Singha22 marked this pull request as ready for review January 14, 2025 16:40
@@ -1037,6 +1123,62 @@ def batch_get_triggers(self, trigger_names: List[str]) -> List[Dict[str, Any]]:
triggers.append(self.triggers[trigger_name].as_dict())
return triggers

@paginate(pagination_model=PAGINATION_MODEL)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see pagination built in immediately!

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for adding these features to Moto @Singha22!

@bblommers bblommers added this to the 5.0.27 milestone Jan 15, 2025
@bblommers bblommers linked an issue Jan 15, 2025 that may be closed by this pull request
@bblommers bblommers merged commit d228659 into getmoto:master Jan 15, 2025
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glue Dev Endpoint API Calls
2 participants