IOTData: Simplify delta calculation #8423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
force-pushed
the
iotdata-simplify-delta-calc
branch
2 times, most recently
from
f323465 to
6834f25
Compare
bblommers
force-pushed
the
iotdata-simplify-delta-calc
branch
from
6834f25 to
0346482
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8423 +/- ##
==========================================
- Coverage 94.60% 94.60% -0.01%
==========================================
Files 1167 1167
Lines 101697 101685 -12
==========================================
- Hits 96210 96198 -12
Misses 5487 5487
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8408
Computing the delta using
jsondiffwas introduced in the very beginning: #1303, and further 'improved' with #7814 and #8342Trying to mangle
jsondiffinto making it behave the way we wanted introduced more problems then it solved though, so this PR simplifies the implementation to compute the delta manually (which turns out to be fairly straightforward).