Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SageMaker: search() now supports the CONTAINS filter #8020

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

bblommers
Copy link
Collaborator

Fixes #8010

@bblommers bblommers added this to the 5.0.14 milestone Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.40%. Comparing base (7f4df58) to head (6653959).
Report is 4 commits behind head on master.

Files Patch % Lines
moto/sagemaker/models.py 83.33% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8020   +/-   ##
=======================================
  Coverage   94.39%   94.40%           
=======================================
  Files        1130     1130           
  Lines       96595    96604    +9     
=======================================
+ Hits        91184    91195   +11     
+ Misses       5411     5409    -2     
Flag Coverage Δ
servertests 29.00% <4.16%> (-0.01%) ⬇️
unittests 94.37% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit 56abecb into getmoto:master Aug 22, 2024
49 of 50 checks passed
@bblommers bblommers deleted the sagemaker-search-contains branch August 22, 2024 08:02
Copy link
Contributor

This is now part of moto >= 5.0.14.dev17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SageMaker Search method for Model Groups not working with Contains filter
1 participant