SQS - Improve delete_message_batch() error responses #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if the input to SQS.delete_message_batch() includes an
invalid receipt handle, moto returns an error:
```
Traceback (most recent call last):
File "test.py", line 26, in <module>
sqs.delete_message_batch(
File "<...>/botocore/client.py", line 391, in _api_call
return self._make_api_call(operation_name, kwargs)
File "<...>/botocore/client.py", line 719, in _make_api_call
raise error_class(parsed_response, operation_name)
botocore.errorfactory.ReceiptHandleIsInvalid: An error occurred (ReceiptHandleIsInvalid) when calling the DeleteMessageBatch operation: The input receipt handle is invalid.
```
However, if the input to Amazon SQS DeleteMessageBatch API includes an
invalid receipt handle, the Amazon SQS API returns the error in Failed
field of an 200 OK response:
```
{
"Successful": [...],
"Failed": [{
"Id": "invalid",
"SenderFault": True,
"Code": "ReceiptHandleIsInvalid",
"Message": 'The input receipt handle "invalid" is not a valid receipt handle.',
}],
"ResponseMetadata": {...},
}
```
This commit updates moto delete_message_batch() method implementation
to return ReceiptHandleIsInvalid errors in the "Failed" field of a
200 OK response instead of failing the entire request.
The implementation follows the implementation of similar functionality
in the SQS change_message_visibility_batch() method. Test case added
to check output in case of a partial failure.
Codecov Report
@@ Coverage Diff @@
## master #4765 +/- ##
==========================================
- Coverage 95.38% 95.38% -0.01%
==========================================
Files 575 575
Lines 61461 61466 +5
==========================================
+ Hits 58626 58630 +4
- Misses 2835 2836 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This is now part of moto >= 2.3.2.dev12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the input to SQS.delete_message_batch() includes an invalid receipt handle, moto returns an error:
However, if the input to Amazon SQS DeleteMessageBatch API includes an invalid receipt handle, the Amazon SQS API returns the error in Failed field of an 200 OK response:
This commit updates moto delete_message_batch() method implementation to return ReceiptHandleIsInvalid errors in the "Failed" field of a 200 OK response instead of failing the entire request.
The implementation follows the implementation of similar functionality in the SQS change_message_visibility_batch() method. Test case added to check output in case of a partial failure.