Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ABC from collections.abc for Python 3.9 compatibility. #2624

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Import ABC from collections.abc for Python 3.9 compatibility. #2624

merged 2 commits into from
Dec 17, 2019

Conversation

tirkarthi
Copy link
Contributor

Importing ABC from collections module has been deprecated since Python 3.4 and removed in Python 3.9. I have made the import fix in compat.py to reuse it across other modules . Reference : python/cpython#10596

@coveralls
Copy link

coveralls commented Dec 10, 2019

Coverage Status

Coverage decreased (-0.1%) to 94.017% when pulling af853dc on tirkarthi:fix-abc-warnings into 4d5bf1c on spulec:master.

@mikegrima
Copy link
Collaborator

Please make the lint fixes.

Copy link
Collaborator

@mikegrima mikegrima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix linting errors.

@tirkarthi
Copy link
Contributor Author

Thanks, fixed the linting errors and CI is green.

Copy link
Collaborator

@mikegrima mikegrima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants