Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning in CMake for shared library #316

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

xbrtszstk
Copy link
Contributor

Title: Add versioning in CMake for shared library

Description:

Hello,
I propose this change to enable building reflect-cpp with Yocto.

Issue:

Without this change, the following error occurs during the build process:

ERROR: reflect-cpp-0.16.0-r0 do_package_qa: QA Issue: -dev package reflect-cpp-dev contains non-symlink .so '/usr/lib/libreflectcpp.so' [dev-elf]
ERROR: reflect-cpp-0.16.0-r0 do_package_qa: Fatal QA errors were found, failing task.
ERROR: Logfile of failure stored in: /workdir/tmp/work/cortexa55-xware-linux/reflect-cpp/0.16.0/temp/log.do_package_qa.1139088
ERROR: Task (/workdir/layers/meta-xhello/recipes-core/reflect-cpp/reflect-cpp_0.16.0.bb:do_package_qa) failed with exit code '1'

Solution:

With this change, the package builds correctly with the proper SOVERSION. Yocto can locate the original .so file in the main package and create a symlink in the *-dev package.

@liuzicheng1987
Copy link
Contributor

@xbrtszstk , do you want to turn this into a Linux package?

@xbrtszstk
Copy link
Contributor Author

xbrtszstk commented Dec 31, 2024

yes, I do. I want to use this library in linux build by yocto.
here you have a link to recipe I'm creating reflect-cpp_git.bb.
Currently, I'm working on support for BSON using mongo-c-driver. Avro and CBOR have issues, because they are linked as static libs, but it's next step.

@liuzicheng1987
Copy link
Contributor

@xbrtszstk , all right, merged.

@liuzicheng1987 liuzicheng1987 merged commit e289f3e into getml:main Dec 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants