Merge branch 'main' into f/capnproto

getml · Dec 22, 2024 · da8db50 · da8db50
2 parents fd3b991 + a1105e9
commit da8db50
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/docs/plugins/people.yml b/docs/plugins/people.yml
@@ -1,14 +1,14 @@
 maintainers:
+- login: liuzicheng1987
+  answers: 0
+  prs: 73
+  avatarUrl: https://avatars.githubusercontent.com/u/19538706?u=1ca794b4e5aa9bbe50277f249e701eea86b0fdd3&v=4
+  url: https://github.com/liuzicheng1987
 - login: Urfoex
   answers: 0
   prs: 4
   avatarUrl: https://avatars.githubusercontent.com/u/1561354?v=4
   url: https://github.com/Urfoex
-- login: liuzicheng1987
-  answers: 0
-  prs: 68
-  avatarUrl: https://avatars.githubusercontent.com/u/19538706?u=1ca794b4e5aa9bbe50277f249e701eea86b0fdd3&v=4
-  url: https://github.com/liuzicheng1987
 experts: []
 last_month_active: []
 top_contributors:
@@ -144,15 +144,19 @@ top_contributors:
   count: 1
   avatarUrl: https://avatars.githubusercontent.com/u/105162544?v=4
   url: https://github.com/Doekin
-top_reviewers:
-- login: lixin-wei
+- login: aligirayhanozbay
   count: 1
-  avatarUrl: https://avatars.githubusercontent.com/u/19600697?u=539692f60ba009b3e2a6a66db90b1fa47be6b0bc&v=4
-  url: https://github.com/lixin-wei
+  avatarUrl: https://avatars.githubusercontent.com/u/44897017?v=4
+  url: https://github.com/aligirayhanozbay
+top_reviewers:
 - login: schaumb
   count: 1
   avatarUrl: https://avatars.githubusercontent.com/u/6457941?u=542743f214f2197bd08b7b7112a2ba1b1e6e73ac&v=4
   url: https://github.com/schaumb
+- login: lixin-wei
+  count: 1
+  avatarUrl: https://avatars.githubusercontent.com/u/19600697?u=539692f60ba009b3e2a6a66db90b1fa47be6b0bc&v=4
+  url: https://github.com/lixin-wei
 - login: StephanTLavavej
   count: 1
   avatarUrl: https://avatars.githubusercontent.com/u/4231088?u=fd10ba4ada8f71ecd4a6be3f4b3cb9993528babc&v=4

diff --git a/include/rfl/json/read.hpp b/include/rfl/json/read.hpp
@@ -8,7 +8,7 @@
 #endif
 
 #include <istream>
-#include <string>
+#include <string_view>
 
 #include "../Processors.hpp"
 #include "../internal/wrap_in_rfl_array_t.hpp"
@@ -30,8 +30,8 @@ auto read(const InputVarType& _obj) {
 
 /// Parses an object from JSON using reflection.
 template <class T, class... Ps>
-Result<internal::wrap_in_rfl_array_t<T>> read(const std::string& _json_str) {
-  yyjson_doc* doc = yyjson_read(_json_str.c_str(), _json_str.size(), 0);
+Result<internal::wrap_in_rfl_array_t<T>> read(std::string_view const _json_str) {
+  yyjson_doc* doc = yyjson_read(_json_str.data(), _json_str.size(), 0);
   if (!doc) {
     return Error("Could not parse document");
   }