Open webview in-app instead of a seperate window on macOS and Windows #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jigar-f
reviewed
Oct 2, 2024
jigar-f
reviewed
Oct 2, 2024
jigar-f
reviewed
Oct 2, 2024
|
@atavism that is a nice improvement over my suggestion! How does Shepherd look opened in the webview? |
|
@Derekf5 Here's what Shepherd looks like in the webview on Windows Screen.Recording.2024-10-02.at.10.03.04.AM.mov |
|
perfect, just wanted to make sure the QR code fit in frame without scrolling, thanks @atavism! |
|
I fixed the issue where the app opens with a Broken UI on Windows as well
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the webview implementation to open the checkout page directly within the app on macOS and Windows, rather than in a separate window. This improves the user experience by keeping navigation seamless and consistent with the rest of the app.
It also includes changes to use webview_windows and some fixes to open the FAQ, forum, and follow us pages in the system browser.
@Derekf5, I know you mentioned opening the webview in a window right next to the main interface. What do you think about opening it directly in-app instead? Here's a video of what it looks like.
Screen.Recording.2024-10-01.at.8.50.48.PM.mov