Enable data cap on iOS #1168
Merged
Enable data cap on iOS #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did some testing and this is working well for me |
jigar-f
reviewed
Sep 11, 2024
| @@ -107,6 +108,10 @@ type StatsTracker interface { | |||
| UpdateStats(string, string, string, int, int, bool) | |||
| } | |||
|
|
|||
| type BandwidthTracker interface { | |||
There was a problem hiding this comment.
thanks for making these changes.
jigar-f
reviewed
Sep 11, 2024
| @@ -11,7 +11,7 @@ import UIKit | |||
|
|
|||
| // For IOS App Lunch time issue | |||
| //https://developer.apple.com/videos/play/wwdc2019/423/?time=305 | |||
| @UIApplicationMain | |||
| @main | |||
There was a problem hiding this comment.
Any reason why we are changing this ?
jigar-f
approved these changes
Sep 11, 2024
|
@atavism I think all API calls to user API fail due to |
|
This issue there because we changes our base URL for User API |
jigar-f
reviewed
Sep 11, 2024
|
|
||
| if strings.HasSuffix(baseURL, common.APIBaseUrl) { | ||
| log.Debug("using proxied.Fronted") | ||
| //this is ios version |
There was a problem hiding this comment.
@atavism For iOS only proxied.Fronted works nothing else.
|
Seems like this is not related to data cap, I have created a ticket here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/getlantern/engineering/issues/1458