Additional updates to ProClient #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atavism
commented
Sep 9, 2024
| } | ||
| } | ||
| return cleaned | ||
| } |
There was a problem hiding this comment.
Just consolidating these changes below
atavism
commented
Sep 9, 2024
internalsdk/auth/auth.go
Outdated
| // The default http.RoundTripper is ChainedNonPersistent which proxies requests through chained servers | ||
| // and does not use keep alive connections. Since no root CA is specified, we do not need to check for an error. | ||
| // Temporarily disable use of ChainedNonPersistent | ||
| // rt, _ := proxied.ChainedNonPersistent("") |
There was a problem hiding this comment.
We can continue using a proxied.ParallelForIdempotent http.RoundTripper for the auth API. I tested it works fine, but I'm leaving the comment here in case we need to re-enable it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.