Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Model Migration Android. #1131

Merged
merged 69 commits into from
Sep 3, 2024
Merged

Conversation

jigar-f
Copy link
Contributor

@jigar-f jigar-f commented Jul 22, 2024

@atavism
Copy link
Contributor

atavism commented Jul 25, 2024

@jigar-f I'm not sure if you wanted me to try testing this yet (I had to pass inAppBilling to PaymentsUtil to get the current code to compile); after doing that, however, it's working great for me. Happy to do more testing whenever it's ready!

@jigar-f
Copy link
Contributor Author

jigar-f commented Jul 25, 2024

@atavism I am working on this, I am making some changes, It should be ready in day or two.

@jigar-f jigar-f self-assigned this Jul 25, 2024
@jigar-f jigar-f added the WIP label Jul 25, 2024
@jigar-f
Copy link
Contributor Author

jigar-f commented Jul 26, 2024

@atavism You can take this for a spin, Most of the changes look good, Let me know if get into any issues.

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@atavism
Copy link
Contributor

atavism commented Aug 27, 2024

@jigar-f I just had two final comments to update some of Go dependencies. LGTM now otherwise! We can share a build for internal testing whenever you think its ready to be merged

@jigar-f
Copy link
Contributor Author

jigar-f commented Aug 28, 2024

Thanks, I am planing to merge this tomorrow and we need this #1113 PR for sharing build, Do you mind reviewing that PR?

@jigar-f
Copy link
Contributor Author

jigar-f commented Aug 28, 2024

@atavism Also you can see the test is failing in CI, I guess for the same reason., Can you take a look into this today, So I can merge this tomorrow?

@atavism
Copy link
Contributor

atavism commented Aug 28, 2024

Thanks, I am planing to merge this tomorrow and we need this #1113 PR for sharing build, Do you mind reviewing that PR?

Taking a look now

@atavism
Copy link
Contributor

atavism commented Aug 30, 2024

@atavism Also you can see the test is failing in CI

If you downgrade go.opentelemetry.io/otel v1.28.0 => v1.19.0, that should resolve the issue. Here's a PR: #1163

@jigar-f
Copy link
Contributor Author

jigar-f commented Aug 30, 2024

Thanks, I will look at this on Monday and merge it. meanwhile I found issue on this PR, and fixed it, you can test it if you want.

atavism and others added 7 commits September 2, 2024 12:14
* merge latest

* downgrade go.opentelemetry.io/otel v1.28.0 => v1.19.0

* downgrade go.opentelemetry.io/otel v1.28.0 => v1.19.0

* Pass checklinkname linker flag.

---------

Co-authored-by: Jigar-f <jigar@getlantern.org>
@atavism
Copy link
Contributor

atavism commented Sep 2, 2024

@jigar-f Just did some more testing with the latest changes, and it's working well for me

@jigar-f jigar-f merged commit 48cec14 into main Sep 3, 2024
1 check passed
@jigar-f jigar-f deleted the jigar/username-password-android branch September 3, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants