-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session Model Migration Android. #1131
Conversation
@jigar-f I'm not sure if you wanted me to try testing this yet (I had to pass inAppBilling to PaymentsUtil to get the current code to compile); after doing that, however, it's working great for me. Happy to do more testing whenever it's ready! |
@atavism I am working on this, I am making some changes, It should be ready in day or two. |
@atavism You can take this for a spin, Most of the changes look good, Let me know if get into any issues. |
@jigar-f I just had two final comments to update some of Go dependencies. LGTM now otherwise! We can share a build for internal testing whenever you think its ready to be merged |
Thanks, I am planing to merge this tomorrow and we need this #1113 PR for sharing build, Do you mind reviewing that PR? |
@atavism Also you can see the test is failing in CI, I guess for the same reason., Can you take a look into this today, So I can merge this tomorrow? |
Taking a look now |
Thanks, I will look at this on Monday and merge it. meanwhile I found issue on this PR, and fixed it, you can test it if you want. |
* merge latest * downgrade go.opentelemetry.io/otel v1.28.0 => v1.19.0 * downgrade go.opentelemetry.io/otel v1.28.0 => v1.19.0 * Pass checklinkname linker flag. --------- Co-authored-by: Jigar-f <jigar@getlantern.org>
@jigar-f Just did some more testing with the latest changes, and it's working well for me |
Ticket-:https://github.com/getlantern/engineering/issues/1475