Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate strings from en.po and pull in latest translations #1093

Merged
merged 16 commits into from
Jun 11, 2024
Merged

Remove duplicate strings from en.po and pull in latest translations #1093

merged 16 commits into from
Jun 11, 2024

Conversation

atavism
Copy link
Contributor

@atavism atavism commented Jun 11, 2024

No description provided.

jigar-f
jigar-f approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@jigar-f jigar-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atavism Changes are LGTM but did you confirm this works, I remember we had to change asset files names due to localization issue?

@atavism
Copy link
Contributor Author

atavism commented Jun 11, 2024 •
edited
Loading

@jigar-f Yep, I confirmed it works (tested all the issues are resolved on desktop and mobile).. Thanks for the review!

@atavism atavism merged commit d716490 into main Jun 11, 2024
1 check passed
@atavism atavism deleted the atavism/issue-1438 branch June 11, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jigar-f jigar-f jigar-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atavism @jigar-f