System tray updates for Windows #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested on Windows and confirmed it resolves the issue https://github.com/getlantern/engineering/issues/1416 |
jigar-f
reviewed
May 24, 2024
jigar-f
reviewed
May 24, 2024
jigar-f
reviewed
May 24, 2024
Thanks! I made those changes (tested on macOS and Windows again) if you wanna take another look |
|
@atavism Looks good on macOS. |
Cool, thanks! Merging then.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/getlantern/engineering/issues/1416
Moves code for managing system tray to separate TrayHandler class and some other improvements