Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip last checkout screen when there's only one payment option available #1069

Merged
merged 16 commits into from
May 13, 2024

Conversation

atavism
Copy link
Contributor

@atavism atavism commented May 7, 2024

@atavism atavism requested a review from jigar-f May 8, 2024 18:07
@atavism
Copy link
Contributor Author

atavism commented May 8, 2024

Looks like the TestProxying test is failing..

    android_test.go:179:
        	Error Trace:	/Users/atavism/go/src/github.com/getlantern/lantern-client/internalsdk/android_test.go:179
        	            				/Users/atavism/go/src/github.com/getlantern/lantern-client/internalsdk/android_test.go:96
        	Error:      	Received unexpected error:
        	            	failed to WebSocket dial: failed to send handshake request: Get "https://relay.lantern.io/allocate": context deadline exceeded
        	Test:       	TestProxying
        	Messages:   	should allocate relay

@atavism
Copy link
Contributor Author

atavism commented May 8, 2024

I'm not sure what the status of replay.lantern.io is. But since messaging is disabled, I'm just gonna disable the tests as well.

lib/plans/plan_details.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@jigar-f jigar-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atavism Just one comment

@atavism
Copy link
Contributor Author

atavism commented May 13, 2024

Thanks for the review, @jigar-f! Just made the changes you requested. Does it look good to you now?

@jigar-f
Copy link
Contributor

jigar-f commented May 13, 2024

Looks good @atavism, Merging.

@jigar-f jigar-f merged commit da8b0fd into main May 13, 2024
2 checks passed
@jigar-f jigar-f deleted the atavism/stripe-desktop-payment-redirect branch May 13, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants