Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with report an issue page #1064

Merged
merged 8 commits into from
May 3, 2024
Merged

Fix issues with report an issue page #1064

merged 8 commits into from
May 3, 2024

Conversation

atavism
Copy link
Contributor

@atavism atavism commented May 2, 2024 •
edited
Loading

Resolves https://github.com/getlantern/engineering/issues/1361

  • When sending a report, it's not obvious that a description is required. Can we make the description optional?
  • Always show "Describe your issue" placeholder text
  • Do not show "send_report" label on mouse hover of Send Report button

jigar-f
jigar-f approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@jigar-f jigar-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atavism atavism merged commit 17efb18 into main May 3, 2024
1 check failed
@atavism atavism deleted the atavism/desktop-report-issue branch May 3, 2024 18:11
@atavism
Copy link
Contributor Author

atavism commented May 3, 2024

Thanks for the review, @jigar-f!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jigar-f jigar-f jigar-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atavism @jigar-f