Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lantern Desktop Beta 8.0.0 collected testing issues #1057

Merged
merged 10 commits into from
Apr 29, 2024

Conversation

atavism
Copy link
Contributor

@atavism atavism commented Apr 29, 2024

Resolves https://github.com/getlantern/engineering/issues/1336

  • Make text fields 56px high on desktop
  • Remove floating label near cursor from text area on report issue screen

Screenshot 2024-04-28 at 9 51 20 PM

@jigar-f jigar-f self-requested a review April 29, 2024 06:49
Copy link
Contributor

@jigar-f jigar-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @atavism

lib/home.dart Show resolved Hide resolved
@atavism
Copy link
Contributor Author

atavism commented Apr 29, 2024

@jigar-f I made one more change to add an ffi method to exit the app (instead of calling SystemChannels.platform.invokeMethod('SystemNavigator.pop') when Exit is selected via the system tray menu.

That seems to work much better. Do the changes still look good to you?

@jigar-f
Copy link
Contributor

jigar-f commented Apr 29, 2024

Let me check.

@jigar-f
Copy link
Contributor

jigar-f commented Apr 29, 2024

@atavism when exit is called by go, it's considered a crash on the flutter end. I see an error related to Crashed Thread: 3 io.flutter.ui I think we should use both, Go will end all go process and flutter will flutter process.

lib/ffi.dart Show resolved Hide resolved
@atavism atavism merged commit 09557a4 into main Apr 29, 2024
1 of 2 checks passed
@atavism atavism deleted the atavism/desktop-8.0.0-issues branch April 29, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants