Fix issue updating user data over websocket #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atavism
commented
Apr 25, 2024
jigar-f
reviewed
Apr 25, 2024
jigar-f
reviewed
Apr 25, 2024
jigar-f
reviewed
Apr 25, 2024
|
@atavism Do you mind taking a look at the new changes? |
atavism
commented
Apr 26, 2024
atavism
commented
Apr 26, 2024
|
@jigar-f Your changes LGTM! Just have that one comment. |
|
@atavism added all the changes. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old Pro client, whenever we fetch user data, it is stored afterwards in a local cache. Whenever that cache changes, the updates are sent over the websocket channel: https://github.com/getlantern/flashlight/blob/main/pro/user_data.go#L154
It looks this was left out of the new Pro client, and we were no longer receiving user data updates in real-time:
lantern-client/lib/common/session_model.dart
Line 94 in 7163452