Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ffiPaymentRedirect to use compute #1048

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

atavism
Copy link
Contributor

@atavism atavism commented Apr 10, 2024

  • Update ffiPaymentRedirect to use compute
  • Add PaymentRedirect API response type
  • Update email exists check to return string instead of pointer

This also fixes an issue on main with desktop where the following error is shown after opening the payment redirect page

Screenshot 2024-04-10 at 3 41 32 PM

@atavism atavism requested a review from jigar-f April 10, 2024 22:44
Copy link
Contributor

@jigar-f jigar-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jigar-f
Copy link
Contributor

jigar-f commented Apr 12, 2024

I am good with this @atavism, Merging...

@jigar-f jigar-f merged commit 22f0dc9 into main Apr 12, 2024
1 of 2 checks passed
@atavism
Copy link
Contributor Author

atavism commented Apr 14, 2024

Thanks for merging and the review, @jigar-f!

@atavism atavism deleted the atavism/compute-ffi-payment-redirect branch April 14, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants