Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dunning): Add create payment requests endpoint #268

Merged
merged 3 commits into from
Sep 4, 2024
Merged

feat(dunning): Add create payment requests endpoint #268

merged 3 commits into from
Sep 4, 2024

Conversation

ancorcruz
Copy link
Contributor

@ancorcruz ancorcruz requested review from nudded and rsempe September 4, 2024 12:34
@ancorcruz ancorcruz self-assigned this Sep 4, 2024
@nudded
Copy link
Contributor

nudded commented Sep 4, 2024

I forgot to write docs about this, but it's best you install ruff (https://docs.astral.sh/ruff/) locally. It will enforce consistent formatting 👍 I'll spend some time on writing some documentation about it.

nudded
nudded approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@nudded nudded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ancorcruz
Copy link
Contributor Author

I forgot to write docs about this, but it's best you install ruff (https://docs.astral.sh/ruff/) locally. It will enforce consistent formatting 👍 I'll spend some time on writing some documentation about it.

Thanks, ruff is happy with the changes in the PR 🎉

@nudded
Copy link
Contributor

nudded commented Sep 4, 2024

Looks like it's not in agreement with the formatting :)

@ancorcruz
Copy link
Contributor Author

Looks like it's not in agreement with the formatting :)

not in my machine 🤣 When I run ruff check finish with All checks passed!...

@ancorcruz ancorcruz merged commit 4e227a2 into main Sep 4, 2024
7 checks passed
@ancorcruz ancorcruz deleted the feat/dunning-create-payment-requests branch September 4, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nudded nudded nudded approved these changes

@rsempe rsempe Awaiting requested review from rsempe

Assignees

@ancorcruz ancorcruz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ancorcruz @nudded