Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate PageHeader #1994

Merged
merged 1 commit into from
Jan 16, 2025
Merged

refactor: migrate PageHeader #1994

merged 1 commit into from
Jan 16, 2025

Conversation

keellyp
Copy link
Collaborator

@keellyp keellyp commented Jan 15, 2025

Context

Related to Tailwind Migration

Description

We used <PageHeader> component with custom children everywhere in the app.
In each file, we were creating the same component group with the same spacing.

This PR should regroup this into a new component :

<PageHeader.Wrapper withSide>
  <PageHeader.Group>
  </PageHeader.Group>
</PageHeader.Wrapper>

@keellyp keellyp self-assigned this Jan 15, 2025
@keellyp keellyp merged commit 4fd6747 into main Jan 16, 2025
4 checks passed
@keellyp keellyp deleted the refactor-page-header branch January 16, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansmonjol ansmonjol ansmonjol approved these changes

Assignees

@keellyp keellyp

Labels
🌈 improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keellyp @ansmonjol