misc(Table): allow to open row link in new tab #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenlago99
approved these changes
Jan 8, 2025
ansmonjol
force-pushed
the
table-row-link
branch
from
655e21c to
b308381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A customer asked to be able to open row link redirection in a new tab.
Description
We're not the best in term of accessibility and it's kinda hard to have a native
alink into a table structure without increasing the complexity of the Table component.I noticed we only use the
onRowActionto execute a navigate all over the app, so decided to rename it and for it to return a string.So we can check if meta or ctrl key are pressed to open in new tab, otherwise use the navigate from
rect-router-domas usual.Put that into the same commit as pretty tied
Fixes ISSUE-615