Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(Gocardless): make sure auth popup opens on any browsers #1812

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ansmonjol
Copy link
Collaborator

We were not using the same behaviour as modal opening, so it was blocking on Safari.

This PR aligns the behaviour with the rest of the app

Fixes ISSUE-436

@ansmonjol ansmonjol added the 🐞 bug Something isn't working label Oct 22, 2024
@ansmonjol ansmonjol self-assigned this Oct 22, 2024
@ansmonjol ansmonjol enabled auto-merge (squash) October 22, 2024 10:14
@ansmonjol ansmonjol merged commit 5f6cdb0 into main Oct 22, 2024
14 checks passed
@ansmonjol ansmonjol deleted the gcl-popup branch October 22, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants