bug(creditNotes) use new BE estimate endpoint to calculate totals #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansmonjol
force-pushed
the
fix-credit-note-taxes-rates
branch
from
5007084 to
177c14c
Compare
ansmonjol
force-pushed
the
fix-credit-note-taxes-rates
branch
from
177c14c to
2b7229d
Compare
ansmonjol
changed the title
ansmonjol
changed the title
vincent-pochet
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We were not receiving enough data on FE side to properly calculate credit notes totals correctly.
Also, it was very hard to calculate and be correct/aligned with BE calculation values.
So we decided to use the BE calculation on the FE side.
Description
On every key down, we send the FE computed values to the BE and it returns the totals based on their calculation logic, including the coupon and taxes pro-rata.