Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: T-965 Generate fees for charges #62

Merged
merged 7 commits into from
Apr 12, 2022
Merged

feat: T-965 Generate fees for charges #62

merged 7 commits into from
Apr 12, 2022

Conversation

vincent-pochet
Copy link
Collaborator

No description provided.

@vincent-pochet vincent-pochet added the enhancement New feature or request label Apr 8, 2022
@vincent-pochet vincent-pochet requested a review from jdenquin April 8, 2022 14:49
@vincent-pochet vincent-pochet self-assigned this Apr 8, 2022
@height
Copy link

height bot commented Apr 8, 2022 •
edited
Loading

This pull request has been linked to 1 task:

💡Tip: Add "Close T-965" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@vincent-pochet vincent-pochet force-pushed the T-965-api-generate-fees-for-charges branch 3 times, most recently from eea560a to b7cabe5 Compare April 8, 2022 15:34
jdenquin
jdenquin approved these changes Apr 9, 2022
View reviewed changes
Copy link
Contributor

@jdenquin jdenquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small comment about fee_serviceotherwise great stuff again 🚀

app/services/fees/charge_service.rb Outdated Show resolved Hide resolved
app/services/fees/charge_service.rb Outdated Show resolved Hide resolved
app/services/fees/charge_service.rb Show resolved Hide resolved
@vincent-pochet vincent-pochet changed the title feat: T-965 Genarate fees for charges feat: T-965 Generate fees for charges Apr 12, 2022
@vincent-pochet vincent-pochet force-pushed the T-965-api-generate-fees-for-charges branch from 1d715f0 to 0e2db6b Compare April 12, 2022 08:21
@vincent-pochet vincent-pochet marked this pull request as ready for review April 12, 2022 10:05
@vincent-pochet vincent-pochet merged commit 1cdcc4d into main Apr 12, 2022
@vincent-pochet vincent-pochet deleted the T-965-api-generate-fees-for-charges branch April 12, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdenquin jdenquin jdenquin approved these changes

Assignees

@vincent-pochet vincent-pochet

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-pochet @jdenquin