feat(credit_notes): Add service to create a credit note #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsempe
reviewed
Oct 11, 2022
rsempe
approved these changes
Oct 11, 2022
vincent-pochet
force-pushed
the
ftr-credit-notes-create
branch
from
909facf to
4f822f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roadmap Task
👉 getlago/lago#59
Context
The objective of this feature is to introduce a new concept of credit notes.
The main reason behind this need is to handle the following case:
in_advance), we charge the customer as if the remainder does not exist.Description
This PR adds the logic to create a credit note from an invoice and a list of fees