feat(credit_notes): Expose credit notes in API #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdenquin
reviewed
Oct 3, 2022
vincent-pochet
force-pushed
the
feature/credit-notes-api
branch
from
84bbc17 to
6ff0b08
Compare
vincent-pochet
changed the title
vincent-pochet
force-pushed
the
feature/credit-notes-api
branch
from
dec2878 to
fd41bbc
Compare
jdenquin
approved these changes
Oct 3, 2022
rsempe
reviewed
Oct 4, 2022
This was referenced Oct 4, 2022
rsempe
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The objective of this feature is to introduce a new concept of credit notes.
The main reason behind this need is to handle the following case:
in_advance), we charge the customer as if the remainder does not exist.Description
This PR exposes two new API routes:
GET /credit_notesto retrieve the paginated list of credit note of an organization or of a specific customerGET /credit_notes/:idto retrieve a specific credit notes