Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Empty webhook URI path sould not raise an error #492

Merged
merged 1 commit into from
Sep 27, 2022
Merged

fix: Empty webhook URI path sould not raise an error #492

merged 1 commit into from
Sep 27, 2022

Conversation

vincent-pochet
Copy link
Collaborator

@vincent-pochet vincent-pochet commented Sep 27, 2022 •
edited
Loading

Context

If a webhook url is set to a domain wihtout path, it raises an error when trying to deliver it.

Description

Instead of trying to send the webhook to a blank path, it should be sent to the root path (/)

@vincent-pochet vincent-pochet added the 🐞 Bug Something isn't working label Sep 27, 2022
@vincent-pochet vincent-pochet self-assigned this Sep 27, 2022
@vincent-pochet vincent-pochet merged commit f0f5479 into main Sep 27, 2022
@vincent-pochet vincent-pochet deleted the fix/empty-webhook-path branch September 27, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdenquin jdenquin jdenquin approved these changes

@lovrocolic lovrocolic Awaiting requested review from lovrocolic

Assignees

@vincent-pochet vincent-pochet

Labels
🐞 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-pochet @jdenquin