Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(invite): remove check on user.id when accepting an invite #479

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

ansmonjol
Copy link
Collaborator

@ansmonjol ansmonjol commented Sep 20, 2022

Context

When building the invite flow, we duplicated the register method.

This method does include a check on the user id, that stops the process if a user with the same email were already existing.

Description

We decided to remove this check in the accept invite flow, in order to allow users to be invited multiple time.

Indeed, as the user is never deleted, this check will make the call fail if a revoked user is invited once again.

We agreed that the situation when the user creates an organization (using the existing register method), then is invited to an organization will not work, as in the frontend we'll need to make a organization switcher in order to make them choose between multiple orga. By default we display the first organization fetched

@ansmonjol ansmonjol added the 🐞 Bug Something isn't working label Sep 20, 2022
@ansmonjol ansmonjol self-assigned this Sep 20, 2022
@ansmonjol ansmonjol changed the title fix: remove check on user.id on invite accept fix(invite): remove check on user.id when accepting an invite Sep 21, 2022
@ansmonjol ansmonjol merged commit 2e941d2 into main Sep 21, 2022
@ansmonjol ansmonjol deleted the accept-invite-errors branch September 21, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants