feat(errors): Convert missing_argument to not_found errors #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsempe
force-pushed
the
missing-argument
branch
from
3972f37 to
24db1f8
Compare
jdenquin
reviewed
Sep 16, 2022
vincent-pochet
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Error handling in services and the way it's rendered in API and GraphQL needs a complete refactoring.
Description
The objective of this PR is to return
404 not_founderrors for existing422 missing_argumentfailures.Concerning GraphQL, it impacts
CreateAppliedAddOn(when customer or add_on not found),CreateAppliedCoupon(when customer or coupon not found) andCreateSubscription(when customer or plan not found).It has been validated that this change does not require updating the frontend, as it only triggers a generic error.
WIP
Need to update
ErrorSerializerto render 404 Not Found for webhooks instead of 422.