Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: T-955 Add service to find billable subscriptions #46

Merged
merged 5 commits into from
Apr 1, 2022

Conversation

vincent-pochet
Copy link
Collaborator

@vincent-pochet vincent-pochet commented Apr 1, 2022

Subscription's billing date cases

With Monthly Plans

With subscription date billing period

  • Day number is less than or equal to the last day of the current month (ie: less than or equal to 28 in february, less than or equal to 30 in april...)
    • Bill on the subscription day number every month, ei: Subscription date is on 13/04, billing will run on the 13th on each month, the billable period is from the 13th to the 12th 11:59pm of the next month.
  • Day number is after last day of the current month (ie: subscription date on 30th but current month is february with only 28 days, subscription date on 31th but current month is april with only 30 days)
    • bill on the last day of the current month

With beginning of period billing period

  • Bill on the first day of each month

With Yearly Plans

With subscription date billing period

  • Subscription day is on 29th of february in a leap year
    • Bill on the 29th of february
  • Subscription day is on 29th of february not in a leap year
    • Bill on the 28th of february
  • Subscription day is any other day (ie: subscription date on 16th)
    • Bill on the subscription anniversary

With beginning of period billing period

  • Bill on the first day of each year

@vincent-pochet vincent-pochet added the enhancement New feature or request label Apr 1, 2022
@vincent-pochet vincent-pochet requested a review from jdenquin April 1, 2022 09:36
@vincent-pochet vincent-pochet self-assigned this Apr 1, 2022
@height
Copy link

height bot commented Apr 1, 2022

This pull request has been linked to 1 task:

💡Tip: Add "Close T-955" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

Copy link
Contributor

@jdenquin jdenquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@vincent-pochet vincent-pochet merged commit 10e4acd into main Apr 1, 2022
@vincent-pochet vincent-pochet deleted the T-955-api-add-count-aggregation-service branch April 1, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants